Rockbox mail archive

• Next message: Mike Holden: "Re: Read errors"
• Previous message: Mike Holden: "Re: Read errors (was:Power Save feature kills playlist playback)"
• In reply to: Mike Holden: "Re: Read errors (was:Power Save feature kills playlist playback)"
• Next in thread: Mike Holden: "Re: Read errors"
• Reply: Mike Holden: "Re: Read errors"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]

Mike Holden wrote:
> We sometimes return 0 for success,
> sometimes for error, but often use "if (somefunction())" type constructs,
> which can be misleading, since the value being tested may not follow the
> usual tradition of 0=true, anything else=false.

Maybe because it's actually the opposite. 0 == false, anything else == true. :-)

But I think you may indeed have found something. 'ret' should be initialized at the top of the loop, not at the bottom.

-- 
Björn

• Next message: Mike Holden: "Re: Read errors"
• Previous message: Mike Holden: "Re: Read errors (was:Power Save feature kills playlist playback)"
• In reply to: Mike Holden: "Re: Read errors (was:Power Save feature kills playlist playback)"
• Next in thread: Mike Holden: "Re: Read errors"
• Reply: Mike Holden: "Re: Read errors"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]