Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: id3.c: reading id3 tags, is this a bug?
From: Linus Nielsen Feltzing (linus_at_haxx.se)
Date: 2003-03-17


TP Diffenbach wrote:
> However, size refers to the size of the frame being read from, in the
> mp3's id3 tag. It seems to me that even if unicode_munge is adjusting
> the size of the copy of the string that we are saving, the size
> remaining on disk in the mp3's id3 tag remains the same. If this is
> the case, size should be set /before/ bytesread is (possibly)
> adjusted by unicode_munge:

You are absolutely correct. Thanks for pointing that out.

> Also, it seems that the call to read should be checked for error or
> EOF:

I agree.

> Thanks.-- Archos FM needs a Rockbox!

Thank you for finding bugs in our code.

/Linus



Page was last modified "Jan 10 2012" The Rockbox Crew
aaa