Rockbox mail archive

• Next message: Björn Stenberg: "Re: Some USB 2.0 questions"
• Previous message: Johan Vromans: "Some USB 2.0 questions"
• In reply to: TP Diffenbach: "id3.c: reading id3 tags, is this a bug?"
• Next in thread: TP Diffenbach: "Re: id3.c: reading id3 tags, is this a bug?"
• Reply: TP Diffenbach: "Re: id3.c: reading id3 tags, is this a bug?"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]

TP Diffenbach wrote:
> However, size refers to the size of the frame being read from, in the
> mp3's id3 tag. It seems to me that even if unicode_munge is adjusting
> the size of the copy of the string that we are saving, the size
> remaining on disk in the mp3's id3 tag remains the same. If this is
> the case, size should be set /before/ bytesread is (possibly)
> adjusted by unicode_munge:

You are absolutely correct. Thanks for pointing that out.

> Also, it seems that the call to read should be checked for error or
> EOF:

I agree.

> Thanks.-- Archos FM needs a Rockbox!

Thank you for finding bugs in our code.

/Linus

• Next message: Björn Stenberg: "Re: Some USB 2.0 questions"
• Previous message: Johan Vromans: "Some USB 2.0 questions"
• In reply to: TP Diffenbach: "id3.c: reading id3 tags, is this a bug?"
• Next in thread: TP Diffenbach: "Re: id3.c: reading id3 tags, is this a bug?"
• Reply: TP Diffenbach: "Re: id3.c: reading id3 tags, is this a bug?"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]