Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: cvs: apps wps.c,1.182,1.183
From: Michael Schopferer (Michael.Schopferer_at_stud.uni-karlsruhe.de)
Date: 2003-03-18


Hello,

there is still a bug in this function. If you pause the playback with
the pitch_screen and resume within the WPS or pause with WPS and
resume within then pitch_screen then is the time between pause and
resume added to the current time in song. This means, the playback
pauses but the time ticks on and is added when you resume.

How can it be? Is there some code, that doesn't get the pause?

I tried to insert the line
mpeg_pause();
after status_set_playmode (as this is the same code as on
BUTTON_PAUSE) but it didn't work either.

This is the same bug I described around the sleeptimer.

Ciao,
Michael

> Update of /cvsroot/rockbox/apps
> In directory sc8-pr-cvs1:/tmp/cvs-serv18660

> Modified Files:
> wps.c
> Log Message:
> Check paused state after pitch screen

> Index: wps.c
> ===================================================================
> RCS file: /cvsroot/rockbox/apps/wps.c,v
> retrieving revision 1.182
> retrieving revision 1.183
> diff -u -b -r1.182 -r1.183
> --- wps.c 15 Mar 2003 12:09:08 -0000 1.182
> +++ wps.c 17 Mar 2003 13:49:52 -0000 1.183
> @@ -819,6 +819,12 @@
> case 1:
> /* was on_screen used? */
> restore = true;
> +
> + /* pause may have been turned off by pitch screen */
> + if (paused && !(mpeg_status() & MPEG_STATUS_PAUSE)) {
> + paused = false;
> + status_set_playmode(STATUS_PLAY);
> + }
> break;
 
> case 0:

-- 
Michael Schopferer *** Michael.Schopferer_at_stud.uni-karlsruhe.de



Page was last modified "Jan 10 2012" The Rockbox Crew
aaa