Rockbox mail archiveSubject: Re: id3.c: reading id3 tags, is this a bug?
From: TP Diffenbach (rockbox_at_diffenbach.org)
Examining the latest CVS with Linus Nielsen Feltzing's changes, I'm still not sure that the code is correct. Specifically, if the read fails (bytes read != bytes requested), I wonder why we shouldn't simply bail out. If we aren't bailing out, I suspect that saze should de decreased by bytesread in all cases; currently sometimes it's reduced by bytesread, sometimes by framelen.
One thing especially confuses me:
A negative return from read, if I recall correctly, means that the read failed. read_frame's caller is only interested in whether read_frame's return value is less than zero. So why mutiply read's return value by ten, and subtract one? What is this useful for?
Incidently, my original question was motivated by a desire to make some changes to id3.c; rather than anyone else making any changes, I'd be glad to do it.
Quoting Linus Nielsen Feltzing <linus_at_haxx.se>:
> TP Diffenbach wrote:
-- Archos FM needs a Rockbox!
Page was last modified "Jan 10 2012" The Rockbox Crew