Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: Crash
From: Mike Holden (rockbox_at_mikeholden.uklinux.net)
Date: 2003-04-12


Johan Vromans said:
> "Mike Holden" <rockbox_at_mikeholden.uklinux.net> writes:
>
>> Mike Holden said:
>> I've looked at merging your patch, but it doesn't apply cleanly to the
>> current CVS version.
>
> Huh? I just applied it to my CVS tree (last updated earlier today) and
> it went in smoothly.
>

I'll have another look. Maybe I need another beer!

> I needed an additional change to get it to build correctly:
>
> --- apps/debug_menu.c~ Thu Apr 10 13:25:02 2003
> +++ apps/debug_menu.c Sat Apr 12 22:25:46 2003
> @@ -802,7 +802,7 @@
> lcd_clear_display();
>
> #ifdef HAVE_CHARGE_CTRL
> - snprintf(buf, 30, "charge_state: %d", charge_state); +
> snprintf(buf, 30, "charge_state: %d", charger_status());
> lcd_puts(0, 0, buf);
>
> snprintf(buf, 30, "Cycle time: %d m",
> powermgmt_last_cycle_startstop_min);

Well caught! My excuse is that that bit of code isn't used on FM!

I've uploaded another patch, which includes that fix, and I've also had a
quick pass at including the battery time remaining value on the status
line. If usb is inserted, then the status line only includes battery icon,
charger inserted icon, runtime (in the form %2dh%02dm so 8h05m for
example) and clock.

http://www.mikeholden.org/~rockbox/patches/battery.diff

-- 
Mike Holden



Page was last modified "Jan 10 2012" The Rockbox Crew
aaa