Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: Re[2]: Battery patch
From: Mike Holden (rockbox_at_mikeholden.uklinux.net)
Date: 2003-04-26


Björn Stenberg said:
> Uwe Freese wrote:
>> I'm voting for committing the patch to CVS, because it works well and
>> the code looks fine. Björn, is it ok if I commit the patch?
>
> Yes, with one change: I want the estimated battery time to be printed on
> the bottom of the screen, below the logo, instead of in the status bar.
> This way it will be visible on players too, and for people that have the
> status bar disabled.

Your wish is my command!

Patch is at http://www.mikeholden.org/~rockbox/patches/battery.diff

Bugs fixed (676339) :
o Fixes animated battery for FM when charging
o Fixes battery status debug screen to show charger plugged and charging
status for FM

Features:
o Shows estimated runtime when USB plugged in at bottom of screen on
recorders/line 2 on player.
o Disables play-related icons when in USB mode (volume, play/stop, shuffle
etc)
o Shows numeric battery level when USB plugged in
o Shows flashing plugged icon when charger inserted when USB plugged in

As before, I have tested it on FM only, but it compiles cleanly on all 3
models, both Normal and Simulator.

In particular, it needs testing on recorder and player, not least because
of the other changes that happened to status.c recently which caused
conflicts I needed to resolve in the patch!

-- 
Mike Holden



Page was last modified "Jan 10 2012" The Rockbox Crew
aaa