Rockbox mail archive

• Next message: Alexandre Belloni: "Re: ext2fs"
• Previous message: Tammy Delahaye: "charger troubles - please help!"
• In reply to: TP Diffenbach: "Re: What function loads a .lang file?"
• Next in thread: TP Diffenbach: "Re: What function loads a .lang file?"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]

TP Diffenbach wrote:
> Well, I'm thinking I'll do it another way anyhow.
>
> But we do have code that assigns pointers to the language strings.
> For example, in settings.c, function set_time

Uh!!! What a bug! We'll have to fix that.

> I wanted to maintain arrays that were subsets of the language_strings
> array, and change mine whenver language_strings was changed.

Why?

> Instead I'm thinking of indexing directly into language_strings.

But that is exactly what the str() macro does. Why not use that?

> Admittly, that fails if the strings in english.lang are reorderd, but
> it doesn't seem to be too much of a burden on maintainers to insist
> that like strings be kept together, and in a certain order.

The current concept depends on the order of the strings. Use the str()
macro and stay out of trouble.

/Linus

• Next message: Alexandre Belloni: "Re: ext2fs"
• Previous message: Tammy Delahaye: "charger troubles - please help!"
• In reply to: TP Diffenbach: "Re: What function loads a .lang file?"
• Next in thread: TP Diffenbach: "Re: What function loads a .lang file?"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]