Rockbox mail archive
Subject: Re: Battery patch
From: Mike Holden (rockbox_at_mikeholden.uklinux.net)
Johan Vromans said:
> "Mike Holden" <rockbox_at_mikeholden.uklinux.net> writes:
>> Johan Vromans said:
>> It should be 1 second on, 1 second off - it is on my FM. Are you using
>> the most recent patch I uploaded later yesterday?
> CVS updated 10:50 UTC. Battery patch uploaded 10:52 UTC (it is
> timestamped yesterday, 21:51 UTC, md5sum
Can confirm this is the latest version I have uploaded.
> (Currently trying to drain the batteries sufficiently to get it
> charging again...)
Let me know how you get on. As I said earlier, it works 1/1 on my FM.
>> I suggested this the other day, but the response was that this was
>> decided against, because when the charge shows 100%, the battery is
>> not actually fully charged, and still needs some more time. Apparently
>> people were removing the charger before the unit was fully charged.
> The blinking plug would indicate that it's still charging. If you
> choose for the option to use this display style, you know what to look
>> There is already a WPS display item for runtime, which I have been
>> using for a while now. I use the status line, so the values are
>> already available on my screen. Where else would you see these items
>> being displayed?
> Currently, with your patch, the status bar on the USB screen always
> displays the battery level as a number, and a blinking plug while
> charging. The non-USB screens have a status bar displaying a steady plug
> and the battery level as a number or graphic (depending on config
> option) or the charging animation while charging.
> I would like to have this consistently in all status bars on all
> screens: a number or graphic depending on config option, and a
> blinking plug or charge animation depending on a new config option.
> For me, the graphic battery plus blinking plug would be the preferred
> -- Johan
I suggested several days ago that I could change this, and asked for
comments. I am happy to change it so that the chosen mode of Numeric or
Graphic battery icon is the one shown. However do we then have an animated
battery and a solid plug icon, animated plug and solid battery, both
animated or what? If we choose Numeric, how can we animate the number? Do
we need an additional configuration for charging animation: Battery, Plug,
Both or None? Maybe better to just choose one or the other (Battery or
Plug animated). Personally I like some indication of battery level, even
if it means that it shows 100% even before the battery is fully charged -
at least I can see that it is nearly 100% rather than still at 40%.
The main work is done, and pretty much anything should be easy to
implement, but which method should I do? Any comments or suggestions would
be welcome :-)
Page was last modified "Jan 10 2012" The Rockbox Crew