Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: Battery patch
From: Johan Vromans (jvromans_at_squirrel.nl)
Date: 2003-04-27


"Mike Holden" <rockbox_at_mikeholden.uklinux.net> writes:

> Let me know how you get on. As I said earlier, it works 1/1 on my
> FM.

Definitely 3/1 on my AJBR20.

> I suggested several days ago that I could change this, and asked for
> comments. I am happy to change it so that the chosen mode of Numeric or
> Graphic battery icon is the one shown. However do we then have an animated
> battery and a solid plug icon, animated plug and solid battery, both
> animated or what? If we choose Numeric, how can we animate the number? Do
> we need an additional configuration for charging animation: Battery, Plug,
> Both or None? Maybe better to just choose one or the other (Battery or
> Plug animated). Personally I like some indication of battery level, even
> if it means that it shows 100% even before the battery is fully charged -
> at least I can see that it is nearly 100% rather than still at 40%.

My suggestion:

  if globalsetting.blinkplug
    show battery as requested (graphic / numeric)
    if charging
      show blinking plug symbol
    else
      show steady plug symbol if charger connected
  else
    show steady plug symbol if charger connected
    if charging
      show animated battery
    else
      show battery as requested (graphic / numeric)

-- Johan



Page was last modified "Jan 10 2012" The Rockbox Crew
aaa