Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: RE: Bookmarking - possible error?
From: Benjamin (mailinglists_at_samuraipanda.com)
Date: 2003-05-13


Sounds like a bug, but I'm not able to reproduce it. It may be something
specific to the studio players.

There shouldn't be anything different between the bookmarking menus and other
menus as I just copied the code and replaced the identifiers. That said, it's
possible that there is some code someplace that initializes everything
correctly. I'll add a note to the readme as to the potential bug.

Glad you enjoy the bookmarking. It's a collaborated effort with me stealing a
bunch of other Rockbox code ;-).

Ben

On Tue, 13 May 2003 09:32:38 -0400, Jonah, Jim wrote
> I still saw the garbage after using bookmarks for a few days.
>
> When I cycled through the options I saw other menu choices appear, including
> this menu's title. However, today when I tried cycling backwards ("-
> " key on the studio 20 player) I finally did run into a "yes"
> choice. BTW, I never found Yes when cycling forward using "+" key.
> Once I selected "Yes", exited, and reentered this menu option the
> only choices that appear are yes and no - which is good.
>
> It seems a little odd that this is the only (so far) new menu item that
> isn't able to display new choices to the user as it's used for the first
> time. Not criticizing, but just curious, what's different about this
> menu that's causing this? To me, this is the only issue I've found
> that would stop if from being a perfect feature. :-)
>
> BTW, I love the bookmarking feature! Thanks for the hard work!!!
>
> Jim
>
> -----Original Message-----
> From: Benjamin [mailto:mailinglists_at_samuraipanda.com]
> Sent: Monday, May 12, 2003 5:17 PM
> To: rockbox_at_cool.haxx.se
> Subject: Re: Bookmarking - possible error?
>
> Short Answer
> ----------------------------------------
> It's expected if this is the first time your run a bookmark enabled
> build. Set it to the value you want and it should be fine from then
> on. If that's not the case, let me know.
>
> Long Answer
> ------------------------------------------
> Nope, it's not "correct behaviour", but it may be expected. If this
> is the first time you are using a bookmark enabled build, the
> bookmark options may be garbaged out because of the way the menus
> are displayed, showing the existing value for that setting, which is
> read up from the stored values. Now, if that value wasn't set, then
> the code will read garbage and display that. Setting it to your
> desired value should correct the issue from then on. Of course,
> since your made the build yourself from the patch, it's possible something
> was
> messed up during the merge. If you continue to have problems, send
> me your source files (not a diff), and I'll try ot look over them
> for problems.
>
> Ben
>
> On Mon, 12 May 2003 16:27:48 -0400, Jonah, Jim wrote
> > On my JukeBox Studio 20, selecting Menu->General
> > Settings->Bookmarking->Maintain a list of Bookmarks?.
> >
> > When I select that option the first line of text lists the option title
> > "Maintain a list of bookmarks?". The second line of text displays garbage
> > characters. Is this correct behaviour?
> >
> > BTW, I enabled bookmarking by using the patch from
> > www.samuraipanda.com/bookmarking-20.zip on the source code from
> > rockbox-daily-20030508.tar.gz. and compiling it on win2k using the cygwin
> > environment distributed on the rockbox web site.
> >
> > Thanks!
> >
> > Jim
> >
> > -----------------
> > Jim Jonah
> > Compuware
> > 248.737.7700
> > ext. 10028
> >
> > "Real programmers don't comment!
> > It was hard to write, It should be hard to read!"
> > -Unknown
> >
> > The contents of this e-mail are intended for the named addressee
> > only. It contains information that may be confidential. Unless you
> > are the named addressee or an authorized designee, you may not copy
> > or use it, or disclose it to anyone else. If you received it in
> > error please notify us immediately and then destroy it.
>
> The contents of this e-mail are intended for the named addressee
> only. It contains information that may be confidential. Unless you
> are the named addressee or an authorized designee, you may not copy
> or use it, or disclose it to anyone else. If you received it in
> error please notify us immediately and then destroy it.



Page was last modified "Jan 10 2012" The Rockbox Crew
aaa