Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: Announce: id3v2 patch 706111 updated
From: Henrik Backe (backe_at_swipnet.se)
Date: 2003-05-23


 Display the strings, that was my intention.
 But I belive you have misread the patch, (it contains both new and old
lines).
After applying the patch the code would look like this (browse_id3() in
apps/wps.c

            case 3:
                lcd_puts(0, 0, str(LANG_ID3_TRACKNUM));
                lcd_puts_scroll(0, 1,
                                id3->track_string ?
                                id3->track_string :
                                (char*)str(LANG_ID3_NO_TRACKNUM));
                break;

            case 4:
                lcd_puts(0, 0, str(LANG_ID3_GENRE));
                lcd_puts_scroll(0, 1,
                                id3->genre_string ?
                                id3->genre_string :
                                wps_get_genre(id3->genre) ?
                                wps_get_genre(id3->genre) :
                                (char*)str(LANG_ID3_NO_INFO));
                break;

            case 5:
                lcd_puts(0, 0, str(LANG_ID3_YEAR));
                lcd_puts_scroll(0, 1,
                                id3->year_string ?
                                id3->year_string :
                                (char*)str(LANG_ID3_NO_INFO));
                break;

../Henrik

"TP Diffenbach" wrote in message
> Good catch Henrik, and thanks.
>
> However, I should note that with my patch, tracknum always has a value if
track_string has a value (namely, atoi( track_string) ), and year always has
a value if year_string does (again, atoi( year_string) ), UNLESS atoi gives
up on it.
>
> Your code uses tracknum preferentially to track_string and year
preferentially to year_string, so those else branches will exedcute only
when there is no id3 tag, or atoi fails to convert it.
>
> So the question is simple: should we display the ints, or the strings?
Potentially, the strings have more information, as in cases like (track)
"11/12" or (year) "1814 (composed), 1982 (recorded)".
>



Page was last modified "Jan 10 2012" The Rockbox Crew
aaa