Rockbox mail archive

Subject: Re: phys2val/val2phys
From: Magnus Holmgren (lear_at_algonet.se)
Date: 2004-01-08

Next message: Magnus Holmgren: "Re: cvs: firmware mp3_playback.c,1.2,1.3"
Previous message: perterm: "AW: Noise while recording."
In reply to: Linus Nielsen Feltzing: "Re: phys2val/val2phys"
Next in thread: Linus Nielsen Feltzing: "Re: phys2val/val2phys"
Reply: Linus Nielsen Feltzing: "Re: phys2val/val2phys"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]

Linus Nielsen Feltzing wrote:

>> Another code question:
>>
>> Why isn't the phys2val() and val2phys() stuff handled internally by
>> mpeg.c/mp3_playback.c?
>>
>
> Define "internally". What do you mean?

So you don't call them in settings.c and other places. If the functions
remain, they'd be declared as static and not be part of the external API.

-- 
Magnus Holmgren

Next message: Magnus Holmgren: "Re: cvs: firmware mp3_playback.c,1.2,1.3"
Previous message: perterm: "AW: Noise while recording."
In reply to: Linus Nielsen Feltzing: "Re: phys2val/val2phys"
Next in thread: Linus Nielsen Feltzing: "Re: phys2val/val2phys"
Reply: Linus Nielsen Feltzing: "Re: phys2val/val2phys"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]

Page was last modified "Jan 10 2012" The Rockbox Crew