Rockbox mail archive

• Next message: Christof Schablinski: "Re: What is RLOD?"
• Previous message: Daniel Stenberg: "Re: patch for building viewers"
• In reply to: Hardeep Sidhu: "Re: WPS tags to display next-song info"
• Next in thread: Hardeep Sidhu: "Re: WPS tags to display next-song info"
• Reply: Hardeep Sidhu: "Re: WPS tags to display next-song info"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]

On Thu, 15 Jan 2004, Hardeep Sidhu wrote:

> I'm guessing that most users will be primarily interested in the next track
> name. This value can be retrieved even if the mpeg thread has not yet
> loaded the track by calling playlist_peek(1). So, how about special casing
> track name and displaying it even if nid3 is NULL.

Good idea. In fact, can't we replace almost all uses of id3->path in there
with a call to playlist_peek(0) for the current song and playlist_peek(1) for
the next one? Do we even need the path in the mp3entry struct?

> BTW. I think there might be a bug in the patch: you're not checking whether
> or not id3 is NULL before trying to access it in get_tag().

Oops. You're right!

-- 
 Daniel Stenberg -- http://rockbox.haxx.se/ -- http://daniel.haxx.se/

• Next message: Christof Schablinski: "Re: What is RLOD?"
• Previous message: Daniel Stenberg: "Re: patch for building viewers"
• In reply to: Hardeep Sidhu: "Re: WPS tags to display next-song info"
• Next in thread: Hardeep Sidhu: "Re: WPS tags to display next-song info"
• Reply: Hardeep Sidhu: "Re: WPS tags to display next-song info"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]