Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: WPS tags to display next-song info
From: Daniel Stenberg (daniel_at_haxx.se)
Date: 2004-01-16


On Thu, 15 Jan 2004, Hardeep Sidhu wrote:

> I'm guessing that most users will be primarily interested in the next track
> name. This value can be retrieved even if the mpeg thread has not yet
> loaded the track by calling playlist_peek(1). So, how about special casing
> track name and displaying it even if nid3 is NULL.

Good idea. In fact, can't we replace almost all uses of id3->path in there
with a call to playlist_peek(0) for the current song and playlist_peek(1) for
the next one? Do we even need the path in the mp3entry struct?

> BTW. I think there might be a bug in the patch: you're not checking whether
> or not id3 is NULL before trying to access it in get_tag().

Oops. You're right!

-- 
 Daniel Stenberg -- http://rockbox.haxx.se/ -- http://daniel.haxx.se/



Page was last modified "Jan 10 2012" The Rockbox Crew
aaa