Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: Various bug fixes and improvements - where to put?
From: Linus Nielsen Feltzing (linus_at_haxx.se)
Date: 2004-03-02


Jens Arnold wrote:
> I worked around the problem by replacing set_irq_level by
> inline assembler (only in lcd_write_data).

I hope you restore the current level and not just set it to 0 to enable
the interrupts again.

The lcd_update() function is called at boot time with the interrupts
disabled, and the sti() call in lcd_write_data() enabled the interrupts
prematurely. This is why I finally decided to remove the cli/sti functions.

Or we could just remove the interrupt disabling in lcd_write_data(). It
isn't needed, because no interrupt changes port B anyway.

Linus

_______________________________________________
http://cool.haxx.se/mailman/listinfo/rockbox



Page was last modified "Jan 10 2012" The Rockbox Crew
aaa