Rockbox mail archive

• Next message: [IDC]Dragon: "Re: Various bug fixes and improvements - where to put?"
• Previous message: Linus Nielsen Feltzing: "Re: Various bug fixes and improvements - where to put?"
• In reply to: Jens Arnold: "Various bug fixes and improvements - where to put?"
• Next in thread: Jens Arnold: "Re: Various bug fixes and improvements - where to put?"
• Reply: Jens Arnold: "Re: Various bug fixes and improvements - where to put?"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]

Jens Arnold wrote:
> I worked around the problem by replacing set_irq_level by
> inline assembler (only in lcd_write_data).

I hope you restore the current level and not just set it to 0 to enable
the interrupts again.

The lcd_update() function is called at boot time with the interrupts
disabled, and the sti() call in lcd_write_data() enabled the interrupts
prematurely. This is why I finally decided to remove the cli/sti functions.

Or we could just remove the interrupt disabling in lcd_write_data(). It
isn't needed, because no interrupt changes port B anyway.

Linus

_______________________________________________
http://cool.haxx.se/mailman/listinfo/rockbox

• Next message: [IDC]Dragon: "Re: Various bug fixes and improvements - where to put?"
• Previous message: Linus Nielsen Feltzing: "Re: Various bug fixes and improvements - where to put?"
• In reply to: Jens Arnold: "Various bug fixes and improvements - where to put?"
• Next in thread: Jens Arnold: "Re: Various bug fixes and improvements - where to put?"
• Reply: Jens Arnold: "Re: Various bug fixes and improvements - where to put?"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]