Rockbox mail archive

• Next message: [IDC]Dragon: "Re: Various bug fixes and improvements - where to put?"
• Previous message: John Donahue: "Re: low-fi mp3s"
• In reply to: Linus Nielsen Feltzing: "Re: Various bug fixes and improvements - where to put?"
• Next in thread: [IDC]Dragon: "Re: Various bug fixes and improvements - where to put?"
• Reply: [IDC]Dragon: "Re: Various bug fixes and improvements - where to put?"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]

Hello Linus

>> I worked around the problem by replacing set_irq_level by
>> inline assembler (only in lcd_write_data).

> I hope you restore the current level and not just set it to 0
> to enable the interrupts again.

Yes, I did store the current irq level in the beginning and
reset it to the same level at the end (I just saved me the
hassle to shift it 4 bits to the right and then back to the
left).
But since both you and Jörg vote for taking it out completely I
will do so before preparing my patches.

Regards, Jens

_______________________________________________
http://cool.haxx.se/mailman/listinfo/rockbox

• Next message: [IDC]Dragon: "Re: Various bug fixes and improvements - where to put?"
• Previous message: John Donahue: "Re: low-fi mp3s"
• In reply to: Linus Nielsen Feltzing: "Re: Various bug fixes and improvements - where to put?"
• Next in thread: [IDC]Dragon: "Re: Various bug fixes and improvements - where to put?"
• Reply: [IDC]Dragon: "Re: Various bug fixes and improvements - where to put?"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]