Rockbox mail archive

• Next message: Rocker: "Re: Advice needed"
• Previous message: Joseph Jones: "Re: AW: AW: AW: Porting Rockbox to XCleff 800 / i.Beat 500"
• In reply to: Linus Nielsen Feltzing: "Re: Safe powerdown feature"
• Next in thread: Linus Nielsen Feltzing: "Re: Safe powerdown feature"
• Reply: Linus Nielsen Feltzing: "Re: Safe powerdown feature"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]

--- Linus Nielsen Feltzing <linus_at_haxx.se> wrote:
> Andreas Stemmer wrote:
>
> > I just noticed that the safe powerdown feature
> spins up the drive every time
> > before shutting down, even if there's nothing to
> write. Are there any
> > reasons for this behaviour?
>
> Yes. There is currently no way of knowing if the
> settings have changed
> or not, so we have to write them to disk every time.
>
> Linus

Since ata_delayed_write is called (indirectly via
settings_save) to update the disk whenever settings
are changed, don't we just need to spin up the disk
only if the delayed_write flag is set, i.e. if a
delayed write is pending?

=====
Craig

rb_dev_at_yahoo.com

                
__________________________________
Do you Yahoo!?
Y! Messenger - Communicate in real time. Download now.
http://messenger.yahoo.com
_______________________________________________
http://cool.haxx.se/mailman/listinfo/rockbox

• Next message: Rocker: "Re: Advice needed"
• Previous message: Joseph Jones: "Re: AW: AW: AW: Porting Rockbox to XCleff 800 / i.Beat 500"
• In reply to: Linus Nielsen Feltzing: "Re: Safe powerdown feature"
• Next in thread: Linus Nielsen Feltzing: "Re: Safe powerdown feature"
• Reply: Linus Nielsen Feltzing: "Re: Safe powerdown feature"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]