Rockbox mail archive

• Next message: Christi Alice Scarborough: "Re: Building RomBox out-of-the-box"
• Previous message: Daniel Stenberg: "Re: Building RomBox out-of-the-box"
• In reply to: Daniel Stenberg: "Re: Building RomBox out-of-the-box"
• Next in thread: Christi Alice Scarborough: "Re: Building RomBox out-of-the-box"
• Reply: Christi Alice Scarborough: "Re: Building RomBox out-of-the-box"
• Reply: BlueChip: "Re: Building RomBox out-of-the-box"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]

Hello Daniel

>> (1) A stray "@echo: not found" is displayed

> Can you figure where/when/why?

Figured it out meanwhile:
In lines 145 and 148 (building rockbox.ucl), you replaced "echo"
by "@echo". However, this part is not makefile syntax, but shell
syntax, and the shell doesn't know "@echo".

>> (2) There are _loads_ of TAB chars in the makefile

> Makefiles are supposed to have heaps of tab characters, and so
> they did even before my patch.

Ah ok. I just wondered because
(1) http://rockbox.haxx.se/docs/contributing.html says:
"Always indent your code with four spaces. Don't use TAB
characters, as that will mess up code display in CVS, printing,
and a zillion other places." and
(2) In some places the indentation indeed does not use TABs, but
multiple spaces.

> Thanks for the feedback.

Np.

Regards, Jens

_______________________________________________
http://cool.haxx.se/mailman/listinfo/rockbox

• Next message: Christi Alice Scarborough: "Re: Building RomBox out-of-the-box"
• Previous message: Daniel Stenberg: "Re: Building RomBox out-of-the-box"
• In reply to: Daniel Stenberg: "Re: Building RomBox out-of-the-box"
• Next in thread: Christi Alice Scarborough: "Re: Building RomBox out-of-the-box"
• Reply: Christi Alice Scarborough: "Re: Building RomBox out-of-the-box"
• Reply: BlueChip: "Re: Building RomBox out-of-the-box"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]