Rockbox mail archive

• Next message: rinty: "Dumped by Christi! Help!! even the MP3 player won't talk to me."
• Previous message: Brian Wolven: "Re: new voice UI feature: file name clips"
• In reply to: Björn Stenberg: "Re: UI and Menu structure rewrite for custom Rockbox - any pointers?"
• Next in thread: Christian Marg: "Re: UI and Menu structure rewrite for custom Rockbox - any pointers?"
• Reply: Christian Marg: "Re: UI and Menu structure rewrite for custom Rockbox - any pointers?"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]

Hello...

Björn Stenberg wrote:

> Christian Marg wrote:
>> Now I wonder: I just have added about 10 Lines of code. Is it
>> normal for a patch of this size to have 27K filesize and Lots of
>> unchanged code in it? I tried reducing it, but then I could no
>> longer apply the patch...
>
>
> It sounds like you've changed the indentation of the code, or in some
> other way include more changes in your patch than you desired.
>
> The -u flag to diff can perhaps be useful. It skips all changes that
> only affects whitespace.

Since my first idea to fix the problem didn't work out as expected (now
that I tried it...), I'll come back to submitting a patch later... ;)

But I'm working on it. Just have to figure out some things in the code.
Am on my way to #rockbox since I don't want to spam/flood the Mailing
list...

bye
Christian

_______________________________________________
http://cool.haxx.se/mailman/listinfo/rockbox

• Next message: rinty: "Dumped by Christi! Help!! even the MP3 player won't talk to me."
• Previous message: Brian Wolven: "Re: new voice UI feature: file name clips"
• In reply to: Björn Stenberg: "Re: UI and Menu structure rewrite for custom Rockbox - any pointers?"
• Next in thread: Christian Marg: "Re: UI and Menu structure rewrite for custom Rockbox - any pointers?"
• Reply: Christian Marg: "Re: UI and Menu structure rewrite for custom Rockbox - any pointers?"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]