On Fri, 1 Jul 2005, cvs@labb.contactor.se wrote:

Nice work, HCl!

Is there some docs/notes anywhere on how to get going with this runtime db?

And some nits on the code:

> +void writetagdbheader(void) {

We normally put the brace in the first column on the next line when we write
functions in Rockbox.

> tagdb_shiftdown(FILERECORD2OFFSET(currentferecord),FILERECORD2OFFSET(restrecord),(tagdbheader.filecount-restrecord)*FILEENTRY_SIZE);

We write code that is less than 80 columns wide.

> + &rundbheader,
> + &rundb_fd,
> + &rundb_initialized,
> strncmp,

Always append new functions last in the struct. That way we don't break
existing plugins.

--- edittoken.h 27 Jun 2005 22:43:11 -0000 1.4
+++ edittoken.h 1 Jul 2005 17:29:44 -0000 1.5
@@ -88,7 +88,7 @@

  struct token {
      char kind;
- char spelling[SPELLING_LENGTH + 1];
+ char spelling[SPELLING_LENGTH + 3];
      long intvalue;
  };

Why the +3 ? AFAIU, the code fills in SPELLING_LENGTH bytes there and I
understand 1 extra for a terminating zero.

Could you perhaps add a comment explaining the 3?

[token.h]
  struct token {
- unsigned char kind;
- char spelling[255]; // 255 should make it aligned again..
- long intvalue;
+ char kind;
+ char spelling[SPELLING_LENGTH + 3];
+ long intvalue;
  };

This is the same struct declared again. Isn't it nicer to have it in just one
header file?

-- 
  Daniel Stenberg -- http://www.rockbox.org/ -- http://daniel.haxx.se/
_______________________________________________
http://cool.haxx.se/mailman/listinfo/rockbox