Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Patch for arbitrary vorbis comments in wps

Patch for arbitrary vorbis comments in wps

From: Mark Arigo <m_arigo_at_yahoo.com>
Date: 2005-08-05

I've submitted a patch to the tracker that allows for
the display of arbitrary vorbis comments (besides the
supported artist, album, year, etc) in the wps.
Vorbis comments take the form TAGNAME=VALUE, so a new
wps variable is used:
%ix"TAGNAME"
quotes included. TAGNAME should match exactly.

For example, I sometimes use a PERFORMER tag if there
are guest artists on a particular track by an artist.
This wps line will display the PERFORMER tag,
otherwise defaults to the artist.
?%ix"PERFORMER"<%ix"PERFORMER"|%ia>

This only works for non-supported tags...%ix"ARTIST"
will not display anything.

The following files were changed:
apps/metadata.c
apps/wps-display.c
firmware/replaygain.c
firmware/exports/id3.h

Currently, only 8 arbitrary vorbis comments are stored
(beyond the supported ones) if they all fit in the
buffer. Since I store the vorbis comments in the
mp3entry.id3v2buf[], I increased its size from 300 to
500 (for iriver), this may be overkill, and can be
reduced.

This patch works for both OGG and FLAC files with
vorbis comments. I'm sure somebody could modify the
apetag metadata handling to do something similar.

The patch (#1252758) is here:
https://sourceforge.net/tracker/index.php?func=detail&aid=1252758&group_id=44306&atid=439120

Mark

__________________________________________________
Do You Yahoo!?
Tired of spam? Yahoo! Mail has the best spam protection around
http://mail.yahoo.com
_______________________________________________
http://cool.haxx.se/mailman/listinfo/rockbox
Received on Fri Aug 5 20:44:27 2005


Page was last modified "Jan 10 2012" The Rockbox Crew
aaa