Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: linus: apps/codecs mpa.c,1.21,1.22

Re: linus: apps/codecs mpa.c,1.21,1.22

From: Magnus Holmgren <lear_at_algonet.se>
Date: 2005-08-23

cvs@labb.contactor.se wrote:

> Modified Files:
> mpa.c
> Log Message:
> iriver: The MP3 codec didn't take the ID3 tag size into account when seeking

Huh? What about the following playback.c:mp3_get_file_pos?

     else if (pos < (int)id3->first_frame_offset)
     {
         /* skip past id3v2 tag and other leading garbage */
         pos = id3->first_frame_offset;
     }

But it does mean something in mpa.c should be changed though. The following:

     if (newpos == 0)
         frame_skip = start_skip;

should probably read:

     if (newpos <= ci->id3->first_frame_offset)
         frame_skip = start_skip;

   Magnus
_______________________________________________
http://cool.haxx.se/mailman/listinfo/rockbox
Received on Tue Aug 23 17:03:42 2005


Page was last modified "Jan 10 2012" The Rockbox Crew
aaa