Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: Try this (remote support)

Re: Try this (remote support)

From: George Styles <ripnetuk_at_gmail.com>
Date: 2005-10-25

Did anyone with commit access get a chance to look at this?

Can I be of any help testing it (i have IHP140) and confirming that it
doesnt break anything else?

Im guessing that the people with commit access will want to look at
the actual code changes, rather than the changed functionaility... i
dont know the rockbox source well enough to do that sadly :(

Im suprised that more people are not interested in this patch

g

On 10/18/05, KÚvin FERRARE <kevin.ferrare.ml@gmail.com> wrote:
> 1 : I can't really wether it works or not since I only own a iRiver
> H140, but I compiled it on on the simulator for all the other devices
> and it just work fine (I ported the button bar for the archos to the
> new multi-screen display layer), also someone with a fm recorder
> tested it and told me the scrolling was as fast as previously
>
> 2 : I didn't looked a lot at the wps code but I can do a "quick hack"
> if it's really necessary (of course, I don't think this kind of things
> should be integrated in CVS)
>
> In fact, the only reason why I'm not implementing the other
> functionnalities is that I don't want to come with a huge unreadable
> 1Mb patch which would obviously be unreadable even for the most
> motivated dev ...
>
> I also disagree with Nobby : CVS is for developpement purpose and some
> functionnalities in it are by nature not fully implemented (just look
> at rockboy, newly added codecs ...) you can't blame devs about that,
> as long as it doesn't prevents existing code from working.
>
> On 10/18/05, George Styles <ripnetuk@gmail.com> wrote:
> > With respect, I disagree with Nobby - i think this is a bit-by-bit
> > development, and once the treeview has been found to work (by being
> > tested by as many as possible), IMHO it should be committed so the
> > patch doesnt get stale against the CVS.
> >
> > After this, the remaining bits (wps, options menu, plugins) can be
> > ported as people feel inspired to do it.
> >
> > I for one am glad that this patch is available, and am using it now
> > with great success :)
> >
> > g
> >
> >
> > On 10/18/05, Nobby Nobbs <nobbynobbs@gmail.com> wrote:
> > > you'd be better getting a working WPS too before you start asking for
> > > testers, i'd gladly try a CVS-ready patch if it was as usable as
> > firefly's
> > > dirty hack :)
> > >
> > >
> > >
> > > On 10/18/05, KÚvin FERRARE <kevin.ferrare.ml@gmail.com> wrote:
> > > > Hi !
> > > >
> > > > I wrote a patch to support the iRiver's remote and I would like to
> > > > have your opinion on the code or if you find some bugs (I have been
> > > > runing it without a crash for 2 weeks, but who knows ...)
> > > >
> > > > (This is not firefly's patch, ithe code is done in a different
> > > > approach : "widget like" )
> > > > Currently, only the filetree is implemented
> > > >
> > > > here is the patch
> > > >
> > >
> > http://sourceforge.net/tracker/index.php?func=detail&atid=439120&group_id=44306&aid=1318081
> > > > Here is a binary version compiled against the current CVS check
> > > (2005/10/18)
> > > > http://timidzone.free.fr/pub/rockbox/remote/rockbox.zip
> > > >
> > > >
> > > >
> > > > cheers,
> > > > KÚvin
> > > >
> > > >
> > >
> > >
> >
> >
>
Received on Tue Oct 25 13:26:09 2005


Page was last modified "Jan 10 2012" The Rockbox Crew
aaa