Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: genlang breaks with less-than and greater-than symbols in quoted strings

genlang breaks with less-than and greater-than symbols in quoted strings

From: James Teh <jamie_at_jantrid.net>
Date: 2006-04-21

Hi all,

In r1.248 of english.lang, line 8492 breaks genlang:
desc: "<All tracks>" entry in tag browser
Running this command:
genlang -o -e=english.lang -t=h300 english.lang
Undefined subroutine &main::All tracks called at ../../tools/genlang line 418, <LANG> line 8493.
I think i have tracked this down to line 318 of genlang:
if(/ *<([^>]*)>/) {
This expression does not check whether the <tag> is outside of a quoted
string. Would a simple fix be to anchor this expression to the start of
the line:
if(/^ *<([^>]*)>/) {
or does this break langv2?

Jamie

-- 
James Teh
Email: jamie@jantrid.net
WWW: http://www.jantrid.net/jamie/
MSN Messenger: jamie@jantrid.net
Jabber: jteh@jabber.org
Yahoo: jcs_teh
Received on Fri Apr 21 06:54:01 2006

Page was last modified "Jan 10 2012" The Rockbox Crew
aaa