Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: X5's joystick instable

Re: X5's joystick instable

From: Nicolas GIF <nicolas.gif_at_free.fr>
Date: Sun, 04 Mar 2007 11:59:40 +0100

Nicolas GIF a écrit :
> I checked all the buttons codes with the debug menu. They're all stable
> exept down :
>
> BUTTON_LEFT = 0x2F
> BUTTON_RIGHT = 0x55
> BUTTON_SELECT = 0x6F
> BUTTON_REC = 0x89
> BUTTON_PLAY = 0xA8
> BUTTON_DOWN = 0xC8 (vary between 0xC8 and 0xD9 when unstable)
> BUTTON_UP = 0xE3
>
> I found in firmware/target/coldfire/iaudio/x5/button-x5.c @ line 96 that
> a code >= to 0xd3 is considered as UP. But in my case DOWN vary up to 0xd9.
>
>
> It would be nice that persons that have the same problem could give the
> highest value the code of down button takes. That way the condition
> (data < 0xd3) could be changed.
>
>

Well, I compiled Rockbox after having changed *if (data < 0xd3)* by *if
(data < 0xdf)* and my problem is gone.

Now the question is : Did this patch works for everyone ??
Received on 2007-03-04


Page was last modified "Jan 10 2012" The Rockbox Crew
aaa