Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: assistance with patch that isn't working.

Re: assistance with patch that isn't working.

From: Andrew Bennett <drewbenn_at_gmail.com>
Date: Thu, 6 Aug 2009 12:49:19 -0700

>
> @@ -910,7 +911,9 @@
> static struct tree_context backup;
> char current[MAX_PATH];
> int last_context;
> -
> + else /* reset current[] */
> + current[0] = '\0';
> +
> backup = tc;
> tc.selected_item = 0;
> tc.dirlevel = 0;
>
>
'else' needs to happen after an 'if'. The patch is being applied in the
wrong place. Maybe it's for a different revision of tree.c?

The place that you got the patch file from might mention a revision number.
Or look at the date that it was posted and checkout a revision closer to
that date.

Instead of figuring out the proper revision, you could try looking around
near that point in tree.c to find an 'if' that deals with 'current', and add
those two lines there (the 'case' part of the patch appears to be in the
right place, but it looks like it was an unintentional change since it only
changed some whitespace). If you're applying the patch file against the
wrong revision, though, you might run into other problems as well.

Drew

---
Andrew Bennett
drewbenn_at_gmail.com

-------------------------------------------------------------------
Unsubscribe: http://cool.haxx.se/cgi-bin/mailman/listinfo/rockbox
FAQ: http://www.rockbox.org/twiki/bin/view/Main/GeneralFAQ
Etiquette: http://www.rockbox.org/mail/etiquette.html
Received on 2009-08-06


Page was last modified "Jan 10 2012" The Rockbox Crew
aaa