Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: dave: apps/plugins/databox edittoken.h,1.5,1.6

Re: dave: apps/plugins/databox edittoken.h,1.5,1.6

From: Dave Chapman <dave_at_dchapman.com>
Date: 2005-11-19

Linus Nielsen Feltzing wrote:
> cvs@labb.contactor.se wrote:
>
>> iPod: signed-char police
>>
>
> Can't we use the -fsigned-char gcc option instead of policing the code?
>
> Linus

As you pondered in irc, policing the code has the advantage of making it
more portable.

I've already fixed all the obvious problems gcc found (i.e. testing if a
var of type "char" was < 0), but I think I would prefer to avoid adding
-fsigned-char unless we run into problems in the future.

Most of the codecs use the int8_t and uint8_t types - which are now
explicitly defined to be signed or unsigned char respectively.

For people who haven't been following this, the C specification says
that plain "char" is either signed or unsigned depending on the
platform. Up to now, all Rockbox platforms (including x86 for the sims)
have had signed chars - but chars are unsigned on ARM.

Dave.
Received on Sat Nov 19 13:47:07 2005


Page was last modified "Jan 10 2012" The Rockbox Crew
aaa