Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Move id3.[ch] and dependencies into apps/ ?

Move id3.[ch] and dependencies into apps/ ?

From: Dave Chapman <dave_at_dchapman.com>
Date: 2006-02-12

All,

I seem to recall that the moving of id3.[ch] and related higher-level
mpeg code from firmware/ to apps/ has been mentioned a few times, and
no-one seemed to object to the idea.

I did a quick test this afternoon, and tried to move the following files
from firmware/ to apps/:

id3.[ch]
mp3data.[ch]
mpeg.[ch]
replaygain.[ch]

This worked fine, with the exception of two functions defined in mpeg.c
- rec_tick() and playback_tick() which are used by mp3_playback.c (a
file I think belongs in firmware/).

There is a comment next to the definition of playback_tick() in mpeg.h
saying "FixMe: get rid of this, use mp3_get_playtime()".

Firstly, does anyone object to moving these files into apps/ ?

Secondly, is anyone familiar with the MAS playback (and recording?)
thread willing to fix those two functions and perform the move of the 8
files I mention?

I would like to add support for reading apev2 tags in mp3 files, and
this could be done efficiently (i.e. without any additional seeks or
reads) if we merged the check for apev2 and id3v1 tags into a single
function.

Thanks,

Dave.
Received on Sun Feb 12 16:23:19 2006


Page was last modified "Jan 10 2012" The Rockbox Crew
aaa