Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: my radio patch

Re: my radio patch

From: Jonathan Gordon <jdgordy_at_gmail.com>
Date: 2006-02-20

bump?
On 16/02/06, Jonathan Gordon <jdgordy@gmail.com> wrote:
> not yet... waiting to see what happens with the wps part before i add
> anything else
> On 16/02/06, Martin Arver <martin.arver@gmail.com> wrote:
> > Jonathan, do you plan on adding a widget like frequency selector? That
> > would be nice. If so, maybe you could use the the code from the
> > equalizer.
> >
> > Martin
> >
> > On 2/13/06, Jonathan Gordon <jdgordy@gmail.com> wrote:
> > > ok, well.. we can either add a menu for the different freq ranges, ot
> > > make em user choosable or something.. minor thing
> > >
> > > anyway.. i now have the current wps code working 100% with the radio
> > > with really minor changes. (well.. actuall it still needs work.. but
> > > it draws everything corectly)
> > > 1 thing i had to add to the code was a new tag so items can be set to
> > > be shown or not depending on which screen is being drawn, i tihnk it
> > > finally works fine..
> > >
> > > now i need some suggestions... because im using a fake id3 struct for
> > > the info (and so wps's dont need to be changed at all) i need to
> > > figure outthe best way to put the info i have from the radio into the
> > > id3 info.. so ye.. here is what can be shown, any suggestions on the
> > > best fields for each one would be good...
> > >
> > > frequency, wheather the radio is tuned or not, stereo, preset number,
> > > preset name, radio mode and radio status
> > >
> > > and now im going to bed
> > >
> > > On 13/02/06, Martin Arver <martin.arver@gmail.com> wrote:
> > > > I think it's hardware dependant, you can check the datasheets for
> > > > info. I know that the irivers can handle the japanese frequencies at
> > > > least. I googled around for this and some sources state 76-92Mhz and
> > > > some others 76-90Mhz. If you allow another frequency band, does that
> > > > mean that the fmr files need to be tagged in some way to tell what
> > > > band they are tailored for?
> > > >
> > > > Martin
> > > > On 2/13/06, Jonathan Gordon <jdgordy@gmail.com> wrote:
> > > > > what are the standard frequencies? the min and max freq's are easy to
> > > > > change, assuming its not hardware dependant..
> > > > > On 13/02/06, Martin Arver <martin.arver@gmail.com> wrote:
> > > > > > As you are working on the radio, perhaps it is time to introduce an
> > > > > > option to select frequency range as well. I believe the users in Japan
> > > > > > would like this change anyway.
> > > > > >
> > > > > > Martin
> > > > > >
> > > > > > On 2/13/06, XavierGr <xaviergr@gmail.com> wrote:
> > > > > > > Nice to hear Jonathan!
> > > > > > >
> > > > > > > I would like to inform the other devs, that I finished updates on the
> > > > > > > multi-fmr patch too.
> > > > > > > It would be good to have a comment for corrections or other possible "bad
> > > > > > > habbits" from a dev.
> > > > > > > That way Jonathan could move more easily to merge if it is commited.
> > > > > > >
> > > > > > > Thanks in advance.
> > > > > > >
> > > > > > >
> > > > > > > On 13/02/06, Jonathan Gordon < jdgordy@gmail.com> wrote:
> > > > > > > > weeee....
> > > > > > > > its actually alot eaiser than i thought it would be to get the wps
> > > > > > > > going... so ignore this patch, ill post up a new one when im done and
> > > > > > > > i have merged it with Xavier's patch
> > > > > > > > On 13/02/06, XavierGr <xaviergr@gmail.com> wrote:
> > > > > > > > > Oh I forgot the link.
> > > > > > > > >
> > > > > > > https://sourceforge.net/tracker/?func=detail&aid=1315353&group_id=44306&atid=439120
> > > > > > > > >
> > > > > > > > >
> > > > > > > > > On 12/02/06, XavierGr <xaviergr@gmail.com> wrote:
> > > > > > > > > > Could we apply an older patch first that enables the user to have
> > > > > > > > > multipreset support (fmr)?
> > > > > > > > > > There is already an updated patch on the tracker.
> > > > > > > > > >
> > > > > > > > > > It changes some parts of the radio.c (and a bit into filetree.c (and
> > > > > > > some
> > > > > > > > > other files)to integrate the fileformat). Except the multipreset
> > > > > > > functions
> > > > > > > > > (load, save, clear preset lists) it will now save preset lists chnages
> > > > > > > only
> > > > > > > > > on radio exit. That way we can avoid many redundant writes to the disk.
> > > > > > > > > >
> > > > > > > > > > Only uggly thing that remains is the appearance of the .fmr filetype
> > > > > > > on
> > > > > > > > > the browser. My thought on this was to let the user choose the fmr file
> > > > > > > (and
> > > > > > > > > if not on the default fmr files folder) then temporarily load the preset
> > > > > > > > > (keeping the last configuratio) and load the radio screen.
> > > > > > > > > >
> > > > > > > > > > Currently (as some devs suggested back then) an fmr file will be shown
> > > > > > > in
> > > > > > > > > the browser but if the user selects it, it will do nothing. (though
> > > > > > > normal
> > > > > > > > > behaviour on radio screen)
> > > > > > > > > >
> > > > > > > > > > What's your thought on this?
> > > > > > > > > >
> > > > > > > > > >
> > > > > > > > > > On 12/02/06, Linus Nielsen Feltzing <linus@haxx.se > wrote:
> > > > > > > > > > > Jonathan Gordon wrote:
> > > > > > > > > > > > so.. does any1 like the idea? or silly waste of time?
> > > > > > > > > > >
> > > > > > > > > > > After a quick glance, it looks like a good start to me.
> > > > > > > > > > >
> > > > > > > > > > > Linus
> > > > > > > > > > >
> > > > > > > > > >
> > > > > > > > > >
> > > > > > > > >
> > > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > > >
> > > > > >
> > > > > >
> > > > >
> > > > >
> > > >
> > > >
> > >
> > >
> >
> >
>
Received on Mon Feb 20 07:54:15 2006


Page was last modified "Jan 10 2012" The Rockbox Crew
aaa