Rockbox mail archiveSubject: Cleaning up duplicate scrolling code.
Cleaning up duplicate scrolling code.
From: Fredrik Íhrn <ohrn_at_chl.chalmers.se>
I was investigating the scrolling bug in bk's multifont patch and realized
So instead of looking for the bug I started out with a patch that removes the
Left to fix is the H100 remote driver which can benefit from the common code
There are 3 obvious solutions:
1. Ignore it and let the duplicate code stay.
2. Add a bunch of ugly wrapper functions to screen_access.c that pass on the
puts_scroll_lcd(int x, int y, const unsigned char *string)
puts_scroll_remote(int x, int y, const unsigned char *string)
And let the function pointers in the struct point to the wrapper instead of
3. Change the API and require all callers to pass in the screen struct.
What you guys think? Should I pursue this further?
Btw, bk's scrolling bug happens because scroll_thread() doesn't have a clue
-- "40 million, son. You have any idea how many patients I had to ignore to get that high score? People died." --Dr. Kelso Fredrik Íhrn Chalmers University of Technology firstname.lastname@example.org SwedenReceived on Sat Mar 11 18:46:54 2006
Page was last modified "Jan 10 2012" The Rockbox Crew