Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: Track skipping & shuffling cause hard lockups.

Re: Track skipping & shuffling cause hard lockups.

From: Hardeep Sidhu <hardeeps_at_pobox.com>
Date: 2006-04-03

gl wrote:
> OK, the lockup is specific to having _both_ shuffle and repeat-shuffle
> enabled. It's caused by this call in playlist.c, line 2431:
>
> playlist_start(0, 0);
>
> It seems extraneous and causes a deadlock in the playback queue system
> - removing it fixes the problem.

Thanks for investigating. I've committed the fix.

> Speaking of repeat-shuffle, I assumed this would work even without
> shuffle on, ie. on the first pass the list plays alphabetically, but
> on subsequent passes it's randomised. However the code only uses it
> if shuffle is also enabled. I think this should be changed.

I was thinking of removing that check as well. If no one disagrees, I
will do so.

-Hardeep
Received on Mon Apr 3 16:03:53 2006


Page was last modified "Jan 10 2012" The Rockbox Crew
aaa