Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: Wavpack skip bug - fixed?

Re: Wavpack skip bug - fixed?

From: Magnus Holmgren <lear_at_algonet.se>
Date: 2006-04-03

gl wrote:

> BTW, can anybody take a look at this (below & see the rest of this
> thread)? Hardeep?
>
> To recap, this in relation to missing the beginning of Wavpack tracks
> when skipping files or dirs manually. Setting both values to zero is
> working for me so far with no ill effects.

Yes, that looks like the proper fix. Q_AUDIO_PLAY take an offset as
argument, anything else ought to be a bug. But I do wonder what Miika
thought when he made those changes (they are fairly recent)... ;)

   Magnus

>>> The problem call comes from audio_thread(), line 1817:
>>>
>>> if (ev.id == SYS_TIMEOUT && play_pending)
>>> {
>>> ev.id = Q_AUDIO_PLAY;
>>> ev.data = (bool *)1;
>>> }
>>>
>>> The offset (ev.data) is set to 1 here - anybody know what's going on?
>>
>> If I set it to 0, tracks play properly (but note it doesn't fix the
>> skip crossfading after all).
>>
>> There's another similarly strange call in initiate_dir_change(), line
>> 1791,
>>
>> queue_post(&audio_queue, Q_AUDIO_PLAY, (bool *)true);
>>
>> And sure enough, if you skip a directory, the start of the first track
>> is missing again.
>>
>> Why are these setting boolean values (especially as true compiles to 1
>> and not -1, which the code would at least treat differently)?? Are
>> these remnants from an old version of the code or am I missing something?
Received on Mon Apr 3 21:39:22 2006


Page was last modified "Jan 10 2012" The Rockbox Crew
aaa