dev builds
themes manual
device status forums
mailing lists
IRC bugs
dev guide

Rockbox mail archive

Subject: Re: A nasty inefficieny in file.c?

Re: A nasty inefficieny in file.c?

From: Magnus Holmgren <>
Date: 2006-07-14

Jens Arnold wrote:

> Another thought:
> Are you listening to mp3? Iirc Slasheri said that the id3
> parser is one such example of inefficiency as it reads
> byte-by-byte....

The id3 parser should read frame by frame, at least according to a quick
look at the code.

Other cases that do read char by char include the WPS reader and the
config file reader (both using misc.c:read_line). Maybe the WPS reader
is the main cause of these one byte reads in that short test run...

Received on Fri Jul 14 16:43:25 2006

Page was last modified "Jan 10 2012" The Rockbox Crew