|
Rockbox mail archiveSubject: RE: using config.cfg instead of config blockRE: using config.cfg instead of config block
From: Davide Gentile <davidegentile_at_earthlink.net>
Date: Fri, 17 Nov 2006 15:51:45 -0500 Hello Jonathan Gordon, I can't build the patch for testing. As of 20061117 I get this error: CC bookmark.c In file included from bookmark.c:41: menu.h:26:34: menus/exported_menus.h: No such file or directory make[1]: *** [/home/user/rockbox-devel/build.h1x0/apps/bookmark.o] Error 1 make: *** [all] Error 2 Also in sim build I get this error: CC stubs.c In file included from /home/user/rockbox-devel/apps/menu.h:25, from stubs.c:27: sound.h:38:5: warning: #warning "No sound in this environment" In file included from /home/user/rockbox-devel/apps/menu.h:25, from stubs.c:27: sound.h:42: error: syntax error before '*' token sound.h:43: error: syntax error before '*' token sound.h:44: error: syntax error before '*' token sound.h:45: error: syntax error before '*' token In file included from stubs.c:27: /home/user/rockbox-devel/apps/menu.h:26:34: menus/exported_menus.h: No such file or directory make[1]: *** [/home/user/rockbox-devel/sim.h1x0/comsim/stubs.o] Error 1 make: *** [all] Error 2 Not sure how much this helps, but I can't test since I can't compile. Sorry. Davide-NYC -----Original Message----- From: rockbox-dev-bounces_at_cool.haxx.se [mailto:rockbox-dev-bounces_at_cool.haxx.se] On Behalf Of Jonathan Gordon Sent: Wednesday, November 15, 2006 8:21 AM To: Rockbox development Subject: Re: using config.cfg instead of config block woohoo! I found the bug, it was the menu callback for the sound settings menu setting low_latency on when it was asking to be shown instead of when it is being entered. So, now its working it is pretty much ready for review, especially the following. - non-volatile settings probably need better handling - middle of menu.c, I have to undef P2STR and P2ID and redefine them or i get compile errors? - dumping the config from the default_event_handler() ? - I have a FIXME next to the rectrigger() call and im not sure why (all recording stuff probably needs fixing/checking - the entire settings_list needs double checking (which i'll probably do tomorrow unless beaten) - anything else I cant think of right now. I've attached the patch because I don't think its quite ready for FS and the wiki is irritating. Please comment so I know what needs fixing. Jonathan On 15/11/06, Jonathan Gordon <jdgordy_at_gmail.com> wrote: > I found the problem... well sort of... > It turns out there is a problem with how dynamic menus are handled. > The way it is supposed to work is that if there is a chance that a > menu should not be displayed then it is given a callback, and return a > special value if the item should not be shown... > now, there is no problem if the callbacks are skipped, (commenting out > menu.c line 429-439 everything works correctly, except no dynamic > menus). > So, its either something blatantly obvious but I've been staring at it > for too long and miss it, or its something wierd and im hoping an > extra pair of eyes (or more?) would be able to see the problem. > Attached is the new patch. > > Also, still waiting on a response to weather useing > default_event_handler() to dump the config file is OK. > > Jonathan > > > Received on 2006-11-17 Page template was last modified "Tue Sep 7 00:00:02 2021" The Rockbox Crew -- Privacy Policy |