Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: next step for the settings changes - the menus

Re: next step for the settings changes - the menus

From: Daniel Stenberg <daniel_at_rockbox.org>
Date: Sun, 28 Jan 2007 14:33:46 +0100 (CET)

On Sun, 28 Jan 2007, Jonathan Gordon wrote:

> The diff does not currently support making menus from just settings (this
> will come ASAP, but wanted to get this email out).

My initial reaction: I dislike how you sprinkle the code with macros that
inserts code (but hides it from the casual reader), so that it looks like
function invokes but is not. Also they hide side effects due to extra
semicolons and re-use of the macro argument in more than one place in the
macro target.

--
  Daniel Stenberg -- http://www.rockbox.org/ -- http://daniel.haxx.se/
Received on 2007-01-28

Page was last modified "Jan 10 2012" The Rockbox Crew
aaa