Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: barrywardell: r12838 - trunk/firmware/common

Re: barrywardell: r12838 - trunk/firmware/common

From: Magnus Holmgren <lear_at_algonet.se>
Date: Mon, 19 Mar 2007 18:49:14 +0100

mailer_at_svn.rockbox.org wrote:

> Log Message:
> Add support for the .precision format in the sprintf()-like functions
> to allow limiting the maximum length of a string.

<...>

> case 's':
> str = va_arg (ap, char*);
> + if(precision > 0)
> + str[precision] = '\0';

Should it really modify the input string like that? What if it is in
flash? (Might not be a problem as currently used, but...)

   Magnus
Received on 2007-03-19


Page was last modified "Jan 10 2012" The Rockbox Crew
aaa