Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: barrywardell: r12838 - trunk/firmware/common

Re: barrywardell: r12838 - trunk/firmware/common

From: Barry Wardell <barry.wardell_at_gmail.com>
Date: Tue, 20 Mar 2007 10:44:49 +0000

Committed to SVN. Thanks for the tip.

Barry

On 3/19/07, Magnus Holmgren <lear_at_algonet.se> wrote:
> Barry Wardell wrote:
>
> >> Should it really modify the input string like that? What if it is in
> >> flash? (Might not be a problem as currently used, but...)
> >>
> >> Magnus
> >>
> >>
> > Good point. Would this be a better way to do it:
>
> <...>
>
> > @@ -160,7 +161,7 @@
> > while (width-- > 0 && ok)
> > ok=push(userp, pad);
> > }
> > - while (*str != '\0' && ok)
> > + while (*str != '\0' && ok && precision--)
> > ok=push(userp, *str++);
> > }
>
> Yes, that looks like a good solution.
>
> Magnus
>
Received on 2007-03-20


Page was last modified "Jan 10 2012" The Rockbox Crew
aaa