Dominik:

I don't see this as a solution to any problem. It doesn't have to be. It should still be up to the theme creator to include the font properly, but at the same time, this patch is also useful to have in many other ways.

I say go for it. Excellent little functionality to have in any case. And small size impact.

-----Original Message-----
From: Dominik Riebeling <dominik.riebeling_at_gmail.com>
Sent: Tuesday, April 17, 2007 12:03 AM
To: Rockbox development <rockbox-dev_at_cool.haxx.se>
Subject: Re: WPS line height patch

As I have took part of the discussion on IRC I won't repeat myself in
total. Just to sum it up: IMO this isn't the proper solution for the
original problem (users mixing wrong fonts with themes). Anyone who's
interested, the discussion was on 20070417 starting about 0:12h

On 4/17/07, Jonathan Gordon <jdgordy_at_gmail.com> wrote:
> I like the patch. and if it is only 200bytes then its a nice band-aid
> fix untill viewports are done

With similar arguments we could introduce the scrolling margins patch
(I know that's bigger but it also was requested much more often) then
...

 - Dominik
Received on 2007-04-17