Jonathan Gordon wrote:
> Questions, comments?

I think it sounds like a good idea. The implementation looks clean and
simple.

1) Why this:

+#define register_ata_idle_func(f) \
+ register_event_callback(EID_ATA_DISK_SPINUP, (event_callback)f)

Why not replace the calls in the ATA code?

2) Question:

> + if (run)
> + callbacks[i].function(NULL);

Is it always true that the callback wants a NULL argument in this case?

Linus
Received on 2007-06-05