Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: christian: r13620 - in trunk/firmware: drivers/audio export

Re: christian: r13620 - in trunk/firmware: drivers/audio export

From: Christian Gmeiner <christian.gmeiner_at_gmail.com>
Date: Tue, 12 Jun 2007 11:39:49 +0200

2007/6/12, Dave Chapman <dave_at_dchapman.com>:
> mailer_at_svn.rockbox.org wrote:
> > Modified: trunk/firmware/drivers/audio/tlv320.c
> > ===================================================================
> > --- trunk/firmware/drivers/audio/tlv320.c 2007-06-11 13:32:29 UTC (rev 13619)
> > +++ trunk/firmware/drivers/audio/tlv320.c 2007-06-11 23:39:07 UTC (rev 13620)
> > @@ -219,10 +219,10 @@
> > }
> >
> > /**
> > - * Mute (mute=true) or enable sound (mute=false)
> > + * Mute (mute=1) or enable sound (mute=0)
> > *
> > */
> > -void audiohw_mute(bool mute)
> > +void audiohw_mute(int mute)
>
> Was there a reason for making this parameter an int in all drivers,
> rather than bool?
>
> I realise that only the tlv320 driver used bool before your commit, but
> that would seem clearer IMO.

I have choosen an int, because more driver used and int before my
changes, but it is also no problem to change it to a bool version.
Will do the change in my next commit - today or tomorrow.

Greets,
Christian
Received on 2007-06-12


Page was last modified "Jan 10 2012" The Rockbox Crew
aaa