Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: HE-AAC in Rockbox

Re: HE-AAC in Rockbox

From: Jonathan Gordon <jdgordy_at_gmail.com>
Date: Sun, 12 Aug 2007 18:50:15 +1000

On 12/08/07, Magnus Holmgren <lear_at_algonet.se> wrote:
> Hi,
>
> Since HE-AAC support is currently only useful on the Gigabeat players
> (and it doesn't seem likely to change anytime soon), what about
> introducing a new config flag, say HAVE_HE_AAC, and set that for the
> Gigabeats only?
>
> I have a patch for it, so I'd especially like to hear arguments against
> it before I commit. :)
>
> Magnus
>
I dont think there is any point. Adding it would just clutter up the
code with more ifdefs, and the hwcodecs (atm) are the only ones which
we were worrying about bin size for, and thats all ifdefed out for
them anyway.

Also, leaving it in means its more likely someone will try to optimize
the codec so more targets can run it.
Received on 2007-08-12


Page was last modified "Jan 10 2012" The Rockbox Crew
aaa