Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: gui_synclist_do_button() changes

Re: gui_synclist_do_button() changes

From: Matthias Mohr <Matthias_at_mohrenclan.de>
Date: Sun, 16 Sep 2007 17:59:26 +0200

Hi Jonathan,

look at the following lines (in apps/tree.c):
-----------------------------------------------------------------------------------------
@@ -640,9 +636,11 @@
                 if ((*tc.dirfilter == SHOW_ID3DB && tc.dirlevel == 0) ||
                     ((*tc.dirfilter != SHOW_ID3DB && !strcmp(currdir,"/"))))
                 {
- if (returned_button == ACTION_STD_CANCEL)
+#ifdef HAVE_LCD_BITMAP
+ if (oldbutton == ACTION_TREE_PGLEFT)
                         break;
                     else
+#endif
                         return GO_TO_ROOT;
                 }

-----------------------------------------------------------------------------------------
The old code does a break in case of "ACTION_STD_CANCEL" and
otherwise it returns GO_TO_ROOT.

In your new code it depends if HAVE_LCD_BITMAP has been set.
If it is set, it breaks in case of "ACTION_TREE_PGLEFT" otherwise it
returns GO_TO_ROOT.
If HAVE_LCD_BITMAP is not set, it always returns GO_TO_ROOT

Was this your intention to remove the check for "ACTION_STD_CANCEL"?

Despite the above I can't find anything unusual - for me it looks fine

with regards,
Matthias
Received on 2007-09-16


Page was last modified "Jan 10 2012" The Rockbox Crew
aaa