Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: Request for testers and reviewers for FS#7774

Re: Request for testers and reviewers for FS#7774

From: Stéphane Doyon <s.doyon_at_videotron.ca>
Date: Fri, 12 Oct 2007 23:45:11 -0400 (EDT)

On Sat, 13 Oct 2007, Daniel Dalton wrote:

> On 13/10/2007 3:10 AM, Stéphane Doyon wrote:
>> The patch was tested on e200, X5, and I believe someone tried it on one
>> of the iRiver models.
>
> That might have been me. But with your whole set of patches it seems to not
> break anything. I will try your latest set today and tell you if I find a
> problem.
> Because I was using an older build with your old set from a while a go.
>
> BTW did you commit anything that touched tree.c?

svn log ... => no.

> I seem to have problems browsing through files and directories.
> The .talk might say.
> "Music"
> Then when I arrow down it says
> "c" then plays the next .talk clip.

Err let's be clear here. This isn't a problem with FS#7774, you are
talking about stock Rockbox, right? That's thread hijacking :-).

> Also the .talk delay is way too long in my opinion. So I might write a patch
> up to shorten it. I guess I would only need to modify two or three lines.

Err... That's been rejected before, and that's the point of FS#7774.

> Also what about your say file type patch?
> What is stopping that from been committed?

As someone else pointed out, FS#7774.

-- 
Stéphane Doyon
<s.doyon_at_videotron.ca>
http://pages.videotron.com/sdoyon/
Received on 2007-10-13

Page was last modified "Jan 10 2012" The Rockbox Crew
aaa