Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: christian: r15632 - in trunk/firmware: . export

Re: christian: r15632 - in trunk/firmware: . export

From: Christian Gmeiner <christian.gmeiner_at_gmail.com>
Date: Fri, 16 Nov 2007 14:02:01 +0100

2007/11/16, Linus Nielsen Feltzing <linus_at_haxx.se>:
> mailer_at_svn.rockbox.org wrote:
> > Modified: trunk/firmware/export/mas35xx.h
> > ===================================================================
> > --- trunk/firmware/export/mas35xx.h 2007-11-15 21:20:29 UTC (rev 15631)
> > +++ trunk/firmware/export/mas35xx.h 2007-11-15 23:32:56 UTC (rev 15632)
> > @@ -22,4 +22,98 @@
> > #ifndef _MAS35XX_H
> > #define _MAS35XX_H
> >
> > +#include "config.h"
> > +
> > +#if CONFIG_CODEC == MAS3507D
> > +static const unsigned int bass_table[] =
> > +{
>
> Ehum. I'm not sure I like to have header files that declare static
> constant data. The same data will be instantiated in every file that
> includes this header file, and that is certainly a waste of memory.
>
> I'ts possible that the compiler/linker can see that the data isn't used
> and remove it, but I still consider it very bad practice.

I will fix this in of my next commits. Atm i am working to get a
general interface for audiohw for software and hardware based players.
Before I will commit my work on this part, I will update the wiki page
and the corresponding patch id in tracker, so that everybody can
review and commit it.
Btw, it seems that the compiler is intellegent enough to fix this
issue when i am looking at
http://build.rockbox.org/cvsmod/sizes-20071115T233352Z

Greets, Christian
Received on 2007-11-16


Page was last modified "Jan 10 2012" The Rockbox Crew
aaa