Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Fix for partymode/database bug? (included in FS#6684)

Fix for partymode/database bug? (included in FS#6684)

From: W. Martin Borgert <debacle_at_debian.org>
Date: Fri, 30 Nov 2007 12:01:14 +0000

Hi,

any chance that the patch
http://labb.contactor.se/tracker/task/6684?getfile=13329
get's applied in SVN?

I don't care for the new feature it implements ("Split the party
mode into two settings") very much, but it also fixes the bug,
that song selection from database interrupts the current song in
party mode. I believe the relevant lines are:

--- filetree.c.orig 2007-11-30 11:54:18.000000000 +0000
+++ filetree.c 2007-11-30 11:55:51.000000000 +0000
@@ -420,6 +420,9 @@
 
                 if (global_settings.party_mode)
                 {
+ if (!playlist_check(1) && playlist_create(NULL, NULL) < 0)
+ break;
+
                     playlist_insert_track(NULL, buf,
                                           PLAYLIST_INSERT_LAST, true, true);
                     gui_syncsplash(HZ, ID2P(LANG_QUEUE_LAST));

Thanks in advance - and thanks for Rockbox!
Received on 2007-11-30


Page was last modified "Jan 10 2012" The Rockbox Crew
aaa