Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: applying multiple patches with one command

Re: applying multiple patches with one command

From: alex wallis <alexwallis646_at_googlemail.com>
Date: Fri, 18 Jan 2008 01:33:51 -0000

Hi stephan
I wrote to you off list but my e mail is being strange, delivering some
messages and not others and not receiving messages from some people at all,
also its not putting messages in my sent items folder. I have written to you
off list, but just thought i'd send to the rb list as an extra check to make
sure you get this, as i did mail you off list before but my mail obviously
decided to be weird.
Anyway in answer to your question, i'm trying to compile for an h140, and
the build error i get is
screens.c:(.text+0x72e): undefined reference to `talk_time'
collect2: ld returned 1 exit status.
----- Original Message -----
From: "Stéphane Doyon" <s.doyon_at_videotron.ca>
To: "Rockbox development" <rockbox-dev_at_cool.haxx.se>
Sent: Friday, January 18, 2008 12:54 AM
Subject: Re: applying multiple patches with one command

On Fri, 18 Jan 2008, alex wallis wrote:

> Hi list.
> I have a question about patches. Earlier today someone sent me a load of
> patches for rockbox.

That would be me :-).

> He very thoughtfully provided me with both one big file of all his
> patches,
> and the patch files individually.
> I applied the big file of patches, and it applied fine I got no errors.
> However when i tried to build a new build of rb it wouldn't build because
> of
> one error in the code of one of the patches something to do with one of
> the
> functions not being used i'm not completely sure.
> However I am very reluctant to not apply his patches just because of one
> error. But He is quite busy so i'm not sure when he will get around to
> fixing
> it and i really don't want to anoy him by seeming to complain, so i'd like
> to

It would have been quite alright to ask :-).

I did do a test compile before sending it out... You must be using a
different target... Tell me off list what player you are building for and
what error you are getting.

> However I was wondering could someone please tell me is there a command i
> can
> use to apply multiple patch files in one go as I haven't been able to find
> out.

The tool I use is called quilt:
http://savannah.nongnu.org/projects/quilt
It manages a stack of patches: push (apply), pop (unapply), and more
importantly you can have it refresh patches when you edit files. VERY
convenient. You'll have to google a bit to see how to get that going under
Cygwin.

Good luck

-- 
Stéphane Doyon
<s.doyon_at_videotron.ca>
http://pages.videotron.com/sdoyon/ 
Received on 2008-01-18

Page was last modified "Jan 10 2012" The Rockbox Crew
aaa