On Sun, 6 Apr 2008, Mike . wrote:

> Looking through FS#8686, there is a lot of code for the Zen port as well as
> some code thats probably useful in general to the m:robe 500 port as well
> since they share the same SOC. A little was added to SVN last month, but
> since then another 200kB worth has accumulated without anyone else
> commenting.
>
> Perhaps we should think about giving Maurus Cuelenaere SVN access so that
> all of this can be kept in sync with the other TMS320 port and the USB
> stack.

I'm not sure that's the reason for the patch not having gotten in yet.

I did the initial commits of a few parts of his work that was clearly only
touching stuff that is ZVM-unique. I'm sure we can go over it again and commit
large chunks of it that have no risk of colliding with other ports.

But, with the little disclaimer that I haven't looked at it lately, the patch
did contain several unconditional changes to generic code that affects the
life of at least the mrobe500 port but possibly also others and such changes
need to be carefully considered (by people faimilar with the ports) and tested
on the affected targets before we commit them.

But of course, giving him SVN commit access will let him start committing
things and gradually allow his external patch to shrink and vanish over time.

-- 
  Daniel Stenberg -- http://www.rockbox.org/ -- http://daniel.haxx.se/