|
Rockbox mail archiveSubject: Re: WPS Developments (wps artists.. take this as a warning..)Re: WPS Developments (wps artists.. take this as a warning..)
From: Thomas Martitz <thomas47_at_arcor.de>
Date: Sun, 01 Jun 2008 13:20:58 +0200 Can you explain why it breaks the progress bar, please? From what I've read on the tracker, it seems you want to remove the restriction to 1 pb per wps. I couldn't read that conditional viewports themselves break it, no matter what. I read "make conditional viewports a bit better.", so I get the impression that you want to push conditional viewports. Am I right? I actually don't think that having more than 1pb is worth breaking every single theme, since I don't see any use for them. 1 pb is IMO exactly what we need. More than 1 are overkill imo. It just makes things more complicated and breaks all themes, while I don't see any sense in that. Please tell me how they are useful and worth the mess. Also, I don't really see how this has something to do with conditional viewports. Seems a bit unrelated to me. Maybe it would be better to discuss the pb thing separately and commit the conditional viewports as they are. Another note on the parameter of %pb: Couldn't we make the first parameter be the filename? So the parameter list wouldn't have to change much in terms of optioniality of parameters. I don't know if some parameters are option, but you wrote "make conditional viewports a bit better.", so I guess there are some optional. When the filename is the first parameter, the others could stay optional. Jonathan Gordon schrieb: > Hey all, > So, I've got a few patches almost ready to go which affect pretty much > every .wps around so I'm putting this warning up to give everyone > plenty of time to fix their wps'. > The two patches which need your attention is > http://www.rockbox.org/tracker/task/9051 and > http://www.rockbox.org/tracker/task/9027. > 9051 removes the ability to set the lcd x/y margins (i.e %m). > 9027 allows you to conditionally display viewports. You should be able > to do anything you could with %m with this patch. The big issue with > this patch is that it breaks the progressbar tags. %P needs to be > removed, so to specify a filename for the progres bar bmp you need to > add it to the end of the %pb tag, which means you have to specify all > 4 number values also. > > I have no intention of commiting either of these before they are > definatly bug free, and without sending out another warning email, but > I'm sending this out now so noone complains that they didnt hear about > this change coming. > > So, summary of changes: > New tags: > %Vl|<tag>|<regular %V syntax>| - tag is a single a-zA-Z letter (like > images...) this tag is used to say that a viewport is conditionally > displayed > %Vd|<tag>| - display a viewport (otherwise not shown on the redraw). > CAVEAT: you need to enable the viewport before its definition or it > wont be drawn... > Removed tags: > %P > Modified tags: > %pb|x|y|width|height|filename| > > This is mostly waiting for 9051 to have its bugs removed which I dont > tihnk will take too long, but 9027 needs more testing... > I'd like to say these will both go in by the end of june (maybe even > devcon weekend..) > > So, please test the patches and let me know of bugs (preferably > replying to the tracker task as I dont watch the user ml...) > > Thanks, > Jonathan > > Received on 2008-06-01 Page template was last modified "Tue Sep 7 00:00:02 2021" The Rockbox Crew -- Privacy Policy |