Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Fix for audio dropout after startup

Fix for audio dropout after startup

From: Martin Buck <m.buck-list_at_bluewin.ch>
Date: Sat, 26 Jul 2008 00:30:40 +0200

Hi,

since a few weeks, I've been noticing short audio dropouts a few seconds
after starting Rockbox on an iAudio X5. I haven't changed any settings
recently (at least I can't remember anything :-) and I haven't done any
Rockbox software upgrades. My guess is that's it's caused by my disk
becoming more and more filled.

Using the debug log, I noticed that the dropouts happen after the "reverse
scan..." message. The "audio thread" debug menu showed me that the dropouts
are caused by PCM buffer underruns. So I added a yield()-call to the
check_deleted_files() function and the dropouts were gone.

The patch below is against a SVN version from a few days ago. I tested it
with an older Rockbox version, but the code looks sufficiently similar that
I don't see why this shouldn't also work with the latest trunk. Could
somebody please apply it?

Thanks,
Martin


diff -ur rockbox-18082.orig/apps/tagcache.c rockbox-18082/apps/tagcache.c
--- rockbox-18082.orig/apps/tagcache.c 2008-07-17 12:45:26.000000000 +0200
+++ rockbox-18082/apps/tagcache.c 2008-07-17 14:34:05.000000000 +0200
_at__at_ -4055,6 +4055,8 _at__at_
             logf("-> %s / %d", buf, tfe.tag_length);
             delete_entry(tfe.idx_id);
         }
+
+ do_timed_yield();
     }
     
     close(fd);
Received on 2008-07-26

Page template was last modified "Tue Sep 7 00:00:02 2021" The Rockbox Crew -- Privacy Policy