Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: Patch review

Re: Patch review

From: Daniel Stenberg <daniel_at_haxx.se>
Date: Thu, 2 Oct 2008 14:38:32 +0200 (CEST)

On Thu, 2 Oct 2008, Björn Stenberg wrote:

> a) select a patch to be reviewed

This is not very easy of course, but how about posting to this list with a
"POTW (oct 7th): FS#1234" style subject and a short motivation, and then at
the actual review time we roll the dice, pick one of the nominated patches and
then we do a collective patch
review/comment/fixing/committing/complaining/celebrating.

Preferably we should try to come up with definite issues that should be fixed
in order to get it committed so that further reviewing mostly would need to
confirm if there are still outstanding issues. Of course we can also
completely reject things if we deem them so.

If we can't find consensus, we mark the patch as RSB material and we send it
off to get a judgement.

> b) select a time for the meeting

May I suggest 22:00 CET (currently that is 20:00 GMT) on let's say Tuesdays?
At least for a first shot at a Euro-oriented version?

Starting at October 7th?

http://timeanddate.com/worldclock/fixedtime.html?month=10&day=7&year=2008&hour=22&min=0&sec=0&p1=239

Alternatively, "someone" picks the particular patch 24 hours before the event
and announces that, so that we can read up and familiarize ourselves with the
patch before the IRC meet. That way we could possibly do more than one patch
each time in case this whole thing works out.

-- 
  / daniel.haxx.se
Received on 2008-10-02

Page was last modified "Jan 10 2012" The Rockbox Crew
aaa