Rockbox.org home
release
dev builds
extras
themes manual
wiki
device status forums
mailing lists
IRC bugs
patches
dev guide



Rockbox mail archive

Subject: Re: jdgordon: r18832 - trunk/apps

Re: jdgordon: r18832 - trunk/apps

From: Dave Chapman <dave_at_dchapman.com>
Date: Fri, 24 Oct 2008 09:51:59 +0100

mailer_at_svn.rockbox.org wrote:
> Date: 2008-10-19 05:58:33 +0200 (Sun, 19 Oct 2008)
> New Revision: 18832
>
> Log Message:
> Dont show lines which have no info in the id3 viewer screen.
>
>
> Modified:
> trunk/apps/screens.c

Why was this feature change committed without any pre-commit discussion
at all? It has since been questioned a few times in IRC.

IMO it's not obvious that this is an improvement - it can be useful to
see the list of tags that Rockbox supports, and which ones are missing
on a particular file. So that screen serves two purposes - to see what
the tags are, and to see what tags are missing.

I'm not saying that I'm completely against it, but I definitely think
these kinds of changes shouldn't be made without any discussion.

Regards,

Dave.
Received on 2008-10-24


Page was last modified "Jan 10 2012" The Rockbox Crew
aaa